-
-
Notifications
You must be signed in to change notification settings - Fork 45.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concatenate/consolidate all algorithms with different implementations #8098
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@digital-dev-07 Read the contributing guidelines.
|
This comment was marked as spam.
This comment was marked as spam.
Please read the contributing guidelines. We do not assign issues in this repository. Instead open a new pull request and add |
This comment was marked as off-topic.
This comment was marked as off-topic.
I am planning to work on this issue but I am having trouble creating a branch. Could you please help me understand? |
The trick is to always create pull requests on a branch other than
If step 1. is not done before step 2. then previous edits can creep in. |
Let's be super careful about deleting the hard work of other people. |
#EDIT:
@CaedenPH Based on your needs, I understand that you want to understand how to connect or merge all algorithms using different implementation methods. Here are some possible methods: Use module import: main.py from maths.primelib import function1, function2, ...
result1 = function1()
result2 = function2() Create a collection of algorithm classes: main_class.py from maths.primelib import AlgorithmClass1, AlgorithmClass2, ...
class MainAlgorithmClass:
def init(self):
self.algo1 = AlgorithmClass1()
self.algo2 = AlgorithmClass2()
def execute_algo1(self):
return self.algo1.function()
def execute_algo2(self):
return self.algo2.function() Using the plugin architecture: |
…8098 (TheAlgorithms#9228) * Removed ciphers/rabin_miller.py as it is already there maths/miller_rabin.py * Renamed miller_rabin.py to rabain_miller.py * Restore ciphers/rabin_miller.py and removed maths/rabin_miller.py
This comment was marked as off-topic.
This comment was marked as off-topic.
@DhanushA1307 We do not assign issues in this repo, just make a PR. Our contributing guidelines already say this, please read them. |
Feature description
There are lots of algorithms with the same concept but different implementations/methods in different files. All these should be moved into one file
The text was updated successfully, but these errors were encountered: